Is there any way to rewrite this method to make it simpler and more efficient? p

Question

Is there any way to rewrite this method to make it simpler and more efficient?

public boolean add(T element) {
Node n = new Node(element);

if (this.contains(element)) {
return false;
}

if (element == null) {
return false;
}
  
if (isEmpty()) {
front = n;
rear = n;
size++;
return true;
}
Node f = front;
Node r = rear;
Node p = null;
  
if (front != null && front.element.compareTo(element) > 0) {
n.next = front;
front = n;
f.prev = n;
size++;
return true;
}
  
if (rear != null && front.element.compareTo(element) < 0) {
rear.next = n;
rear = n;
n.prev = r;
size++;
return true;
}
  
while (front.next != null && front.element.compareTo(element) < 0){
p = f;
f = f.next;
}
n.next = p.next;
p.next = n;
f.prev = n;
n.prev = p;
size++;
return true;
}

Explanation / Answer

public boolean add(T element) {
Node n = new Node(element);

if (this.contains(element) && (element == null)) {
return false;
}

     
if (isEmpty()) {
front = rear = n;
size++;
return true;
}
Node f = front;
Node r = rear;
Node p = null;
  
if (front != null && front.element.compareTo(element) > 0) {
n.next = front;
front = f.prev = n;
size++;
return true;
}
  
if (rear != null && front.element.compareTo(element) < 0) {
rear.next = n;
rear = n;
n.prev = r;
size++;
return true;
}
  
while (front.next != null && front.element.compareTo(element) < 0){
p = f;
f = f.next;
}
n.next = p.next;
p.next =f.prev = n;
n.prev = p;
size++;
return true;
}

Related Questions

Navigate

• Browse (All)
• Browse I
• Subjects

Integrity-first tutoring: explanations and feedback only — we do not complete graded work. Learn more.