Academic Integrity: tutoring, explanations, and feedback — we don’t complete graded work or submit on a student’s behalf.

C++ minesweeper with command line arguments I can\'t figure out what\'s with my

ID: 3677492 • Letter: C

Question

C++ minesweeper with command line arguments

I can't figure out what's with my code to get the command line input to run through

#include <iostream>
#include<cstdlib>
#include<time.h>

using namespace std;
int r,c,m;
int MINES,MINE;
const char COVERED = 'X';
const char UNCOVERED = ' ';
const char FLAG = 'F';
int state[r][c];
char display[r][c];

void check_argc(int argc);
void data_storage(char *argv[],int argc, int &r, int &c, int &m);
void check_good_value(int &num);
void define_variables(int &r, int &c, int &m);
void init(); // initialize game states
int countSorroundingMines(int x, int y); // helper function used by init
void reveal(int x, int y);
void player(); // handle player input
void setFlag();
void uncover();
void print(); // print the minefield
bool isWin();
bool isLose();
bool playNewGame();

void check_argc(int argc)
{
   if(argc != 7){
       exit(1);
   }
}

void data_storage(char *argv[], int argc, int &r, int &c, int &m)
{
   for(int i = 1; i< argc; i+=2){
       if(argv[i][0] == '-' && argv[i][1] == 'r' && argv[i][2] == '')
           r = atoi(argv[i+1]);
       if(argv[i][0] == '-' && argv[i][1] == 'c' && argv[i][2] == '')
           c = atoi(argv[i+1]);
       if(argv[i][0] == '-' && argv[i][1] == 'm' && argv[i][2] == '')          
           m = atoi(argv[i+1]);
   }
}


void define_variables(int &r, int &c, int &m)
{
   cout<< "Rows: " << r << endl;
       check_good_value(r);
   cout<< "Columns: " << c << endl;
       check_good_value(c);
   cout << "Mines: " << m << endl;
       check_good_value(m);
}

void check_good_value(int &num){
   char store[256];
   int x = 0;
   while(x== 0) {
       if(num <= 0){
           cout<<"Input doesn't work"<<endl;
           cout<<"please input a number greater than 0:";
           cin>>store;
           num = atoi(store);
           }
       if(num > 0){
           x = 1;
           }
   }
}


void init()
{
   cout << "New Game!" << endl;
   // set display to "uncovered"
   for(int y = 0; y < c; y++)
{
       for(int x = 0; x < r; x++)
      {
           display[x][y] = COVERED;
   }
}
   // initialize mines
   srand(time(0));
   for(int i = 0; i < MINES; i++)
{
       bool placed = false;
       while(!placed)
   {
           int x = rand() % r;
       int y = rand() % c;
       if(state[x][y] != MINE)
          // check mine not set
{
               placed = true;
       state[x][y] = MINE;
}
}
}
// place hint numbers
for(int y = 0; y < c; y++)
{
   for(int x = 0; x < r; x++)
   {
state[x][y] = countSorroundingMines(x, y);
}
}
}


bool playNewGame()
{
   bool selected = false;
   while(!selected){
   char choice;
   cout<<"Play another game? Y or N" << endl;
   cin>>choice;
   if(choice == 'N' || choice == 'n'){
       return false;
       selected = true;
   }
   else if(choice == 'Y' || choice == 'y'){
       return true;
       selected = true;
   }
   else{
   cout<<"That is not a valid choice"<<endl;
       }
   }
   return false;
}



void reveal(int x, int y) {
if(x >= 0 && x < c && y >= 0 && y < c) { // check that x and y are valid
if(display[x][y] == UNCOVERED) {
return;
}
display[x][y] = UNCOVERED;

if(state[x][y] == m || state[x][y] != 0) {
return;
}
reveal(x - 1, y - 1);
reveal(x, y - 1);
reveal(x + 1, y - 1);
reveal(x - 1, y);
reveal(x + 1, y);
reveal(x - 1, y + 1);
reveal(x, y + 1);
reveal(x + 1, y + 1);
} else {
return;
}
}

/*
[x-1, y-1][x, y-1][x+1, y-1]
[x-1, y ][x, y ][x+1, y ]
[x-1, y+1][x, y+1][x+1, y+1]
*/
int countSorroundingMines(int x, int y) {
if(state[x][y] == m) {
return m;
}
int num = 0;
if(x > 0 && y > 0) { // top left
if(state[x - 1][y - 1] == m) {
num++;
}
}
if(y > 0) { // top
if(state[x][y - 1] == m) {
num++;
}
}
if(x < r - 1 && y > 0) { // top right
if(state[x + 1][y - 1] == m) {
num++;
}
}
if(x > 0) { // left
if(state[x - 1][y] == m) {
num++;
}
}
if(x < r - 1) { // right
if(state[x + 1][y] == m) {
num++;
}
}
if(x > 0 && y < c - 1) { // bottom left
if(state[x - 1][y + 1] == m) {
num++;
}
}
if(y < c - 1) { // bottom
if(state[x][y + 1] == m) {
num++;
}
}
if(x < r - 1 && y < c - 1) { // bottom right
if(state[x + 1][y + 1] == m) {
num++;
}
}
return num;
}

bool isWin() {
bool win = true;
for(int y = 0; y < c; y++) {
for(int x = 0; x < r; x++) {
win &= ((display[x][y] == UNCOVERED && state[x][y] != MINE) ||
((display[x][y] == COVERED || display[x][y] == FLAG) && state[x][y] == MINE));
}
}
return win;
}

bool isLose() {
for(int y = 0; y < c; y++) {
for(int x = 0; x < r; x++) {
if (display[x][y] == UNCOVERED && state[x][y] == MINE) {
return true;
}
}
}
return false;
}

void uncover() {
bool selected = false;
while(!selected) {
int x;
int y;
cout << "Input X (1 - " << (r) << ")" << endl;
cin >> x;
cout << "Input Y (1 - " << (c) << ")" << endl;
cin >> y;
x--;
y--;
if(x >= 0 && x < r && y >= 0 && y < c) {
reveal(x, y); // call recursive reveal algorithm
selected = true;
} else {
cout << "(X,Y) Values out of range!" << endl;
}
}
}

void player() {
cout << "Commands: R => Show, C ==> Cheat, F => Flag, N => NewGame" << endl;
bool selected = false;
while(!selected) {
char choice;
cin >> choice;
if(choice == 'R' || choice == 'r') {
uncover();
selected = true;
} else if(choice == 'F' || choice == 'f') {
setFlag();
selected = true;
} else if(choice == 'C' || choice == 'c') {
//cheat();
} else if(choice == 'N' || choice == 'n') {
init();
selected = true;
} else {
cout << "Invalid Choice!" << endl;
}
}

}

void setFlag() {
bool selected = false;
while(!selected) {
int x;
int y;
cout << "Input X (1 - " << (r) << ")" << endl;
cin >> x;
cout << "Input Y (1 - " << (c) << ")" << endl;
cin >> y;
x--;
y--;
if(x >= 0 && x < r && y >= 0 && y < c) {
display[x][y] = FLAG;
selected = true;
} else {
cout << "(X,Y) Values out of range!" << endl;
}
}
}

void cheat() {
cout << "Only this once!!" << endl;
cout << " ";
for(int x = 0; x < r; x++) {
cout << (x + 1) << " ";
}
cout << endl << "";
for(int x = 0; x < r; x++) {
cout << "";
}
cout << endl;
for(int y = 0; y < c; y++) {
cout << (y + 1) << " ";
for(int x = 0; x < c; x++) {
if(state[x][y] == m) {
cout << "@ ";
} else {
if(state[x][y] == 0) {
cout << " ";
} else {
cout << state[x][y] << " ";
}
}
}
cout <<endl;
}
}

void print()
{
cout << " ";
for(int x = 0; x < r; x++) {
cout << (x + 1) << " ";
}
cout << endl << "";
for(int x = 0; x < r; x++) {
cout << "";
}
cout << endl;
for(int y = 0; y < c; y++) {
cout << (y + 1) << " ";
for(int x = 0; x < c; x++) {
if(display[x][y] == COVERED || display[x][y] == 'F') { // is it tile still uncovered
cout << display[x][y] << " ";
} else { // display the state
if(state[x][y] == MINE) {
cout << "@ ";
} else {
if(state[x][y] == 0) {
cout << " ";
} else {
cout << state[x][y] << " ";
}
}
}
}

cout <<endl;
}
}

int main(int argc, char *argv[]) {
   cout << "Welcome to MineSweeper!" << endl;
   int m=0,r=0,c=0;

   check_argc(argc);
   data_storage(argv,argc,r,c,m);
   define_variables(r,c,m);
   cout<<"Time to initialize!"<<endl;

   init();
   bool playing = true;
   while(playing) {
   print();
   player();
   if(isWin()) {
       cout << "You Win!" <<endl;
       playing = false;
       } else if(isLose()) {
           cout << "You Lose!" << endl;
       playing = false;
       }
   if(!playing) {
       playing = playNewGame();
       if(playing) {
           init();
}
}
}
   cout << "Exiting Minesweeper!" << endl;
   return 0;
}

Explanation / Answer

You can't declare an array using size as an input integer. Either you have to depend on probable array size 10 like as follows;

int state[r][c]; is wrong and similarly other arrays defined are also wrong.
int state[10][10]; // you have to declare like this

otherwise you can use std::vector<> instead of array.

## You have to define the Row and colums i.e the dimensions before only if you are defining array globally.
here is the corected code.

#include <iostream>
#include<cstdlib>
#include<ctime>

const int DIMX = 6;

const int DIMY = 6;

const int MINES = 6;

const int MINE = -1;

const char COVERED = 'X';

const char UNCOVERED = ' ';

const char FLAG = 'F';

int state[DIMX][DIMY];

char display[DIMX][DIMY];

void init(); // initialize game states

int countSorroundingMines(int x, int y); // helper function used by init

void reveal(int x, int y);

void player(); // handle player input

void setFlag();

void uncover();

void print(); // print the minefield

void cheat(); // print out the mines

bool isWin();

bool isLose();

bool playNewGame();

int main() {
std::cout << "Welcome to MineSweeper!" << std::endl;
init();
bool playing = true;
while(playing) {
print();
player();
if(isWin()) {
std::cout << "You Win!" << std::endl;
playing = false;
} else if(isLose()) {
std::cout << "You Lose!" << std::endl;
playing = false;
}

if(!playing) {
playing = playNewGame();
}
}
std::cout << "Exiting Minesweeper!" << std::endl;
return 0;
}

void init() {
std::cout << "New Game!" << std::endl;
// set display to "uncovered"
for(int y = 0; y < DIMY; y++) {
for(int x = 0; x < DIMX; x++) {
display[x][y] = COVERED;
}
}
// initialize mines
srand(time(0));
for(int i = 0; i < MINES; i++) {
bool placed = false;
while(!placed) {
int x = rand() % DIMX;
int y = rand() % DIMY;
if(state[x][y] != MINE) { // check mine not set
placed = true;
state[x][y] = MINE;
}
}
}
// place hint numbers
for(int y = 0; y < DIMY; y++) {
for(int x = 0; x < DIMX; x++) {
state[x][y] = countSorroundingMines(x, y);
}
}
}

bool playNewGame() {
bool selected = false;
while(!selected) {
char choice;
std::cout << "Play another game? Y or N" << std::endl;
std::cin >> choice;
if(choice == 'N' || choice == 'n') {
return false;
selected = true;
} else if(choice == 'Y' || choice == 'y') {
return true;
selected = true;
} else {
std::cout << "(X,Y) Values out of range!" << std::endl;
}
}
}

void reveal(int x, int y) {
if(x >= 0 && x < DIMX && y >= 0 && y < DIMY) { // check that x and y are valid
if(display[x][y] == UNCOVERED) {
return;
}
display[x][y] = UNCOVERED;

if(state[x][y] == MINE || state[x][y] != 0) {
return;
}
reveal(x - 1, y - 1);
reveal(x, y - 1);
reveal(x + 1, y - 1);
reveal(x - 1, y);
reveal(x + 1, y);
reveal(x - 1, y + 1);
reveal(x, y + 1);
reveal(x + 1, y + 1);
} else {
return;
}
}

/*
[x-1, y-1][x, y-1][x+1, y-1]
[x-1, y ][x, y ][x+1, y ]
[x-1, y+1][x, y+1][x+1, y+1]
*/
int countSorroundingMines(int x, int y) {
if(state[x][y] == MINE) {
return MINE;
}
int num = 0;
if(x > 0 && y > 0) { // top left
if(state[x - 1][y - 1] == MINE) {
num++;
}
}
if(y > 0) { // top
if(state[x][y - 1] == MINE) {
num++;
}
}
if(x < DIMX - 1 && y > 0) { // top right
if(state[x + 1][y - 1] == MINE) {
num++;
}
}
if(x > 0) { // left
if(state[x - 1][y] == MINE) {
num++;
}
}
if(x < DIMX - 1) { // right
if(state[x + 1][y] == MINE) {
num++;
}
}
if(x > 0 && y < DIMY - 1) { // bottom left
if(state[x - 1][y + 1] == MINE) {
num++;
}
}
if(y < DIMY - 1) { // bottom
if(state[x][y + 1] == MINE) {
num++;
}
}
if(x < DIMX - 1 && y < DIMY - 1) { // bottom right
if(state[x + 1][y + 1] == MINE) {
num++;
}
}
return num;
}

bool isWin() {
bool win = true;
for(int y = 0; y < DIMY; y++) {
for(int x = 0; x < DIMX; x++) {
win &= ((display[x][y] == UNCOVERED && state[x][y] != MINE) ||
((display[x][y] == COVERED || display[x][y] == FLAG) && state[x][y] == MINE));
}
}
return win;
}

bool isLose() {
for(int y = 0; y < DIMY; y++) {
for(int x = 0; x < DIMX; x++) {
if (display[x][y] == UNCOVERED && state[x][y] == MINE) {
return true;
}
}
}
return false;
}

void player() {
std::cout << "Commands: R => reveal square, F => set flag, C => cheat, N => New Game" << std::endl;
bool selected = false;
while(!selected) {
char choice;
std::cin >> choice;
if(choice == 'R' || choice == 'r') {
uncover();
selected = true;
} else if(choice == 'F' || choice == 'f') {
setFlag();
selected = true;
} else if(choice == 'C' || choice == 'c') {
cheat();
} else if(choice == 'N' || choice == 'n') {
init();
selected = true;
} else {
std::cout << "Invalid Choice!" << std::endl;
}
}

}

void uncover() {
bool selected = false;
while(!selected) {
int x;
int y;
std::cout << "Input X (1 - " << (DIMX) << ")" << std::endl;
std::cin >> x;
std::cout << "Input Y (1 - " << (DIMY) << ")" << std::endl;
std::cin >> y;
x--;
y--;
if(x >= 0 && x < DIMX && y >= 0 && y < DIMY) {
reveal(x, y); // call recursive reveal algorithm
selected = true;
} else {
std::cout << "(X,Y) Values out of range!" << std::endl;
}
}
}

void setFlag() {
bool selected = false;
while(!selected) {
int x;
int y;
std::cout << "Input X (1 - " << (DIMX) << ")" << std::endl;
std::cin >> x;
std::cout << "Input Y (1 - " << (DIMY) << ")" << std::endl;
std::cin >> y;
x--;
y--;
if(x >= 0 && x < DIMX && y >= 0 && y < DIMY) {
display[x][y] = FLAG;
selected = true;
} else {
std::cout << "(X,Y) Values out of range!" << std::endl;
}
}
}

void cheat() {
std::cout << "Cheating is bad!" << std::endl;
std::cout << " ";
for(int x = 0; x < DIMX; x++) {
std::cout << (x + 1) << " ";
}
std::cout << std::endl << "";
for(int x = 0; x < DIMX; x++) {
std::cout << "";
}
std::cout << std::endl;
for(int y = 0; y < DIMY; y++) {
std::cout << (y + 1) << " ";
for(int x = 0; x < DIMX; x++) {
if(state[x][y] == MINE) {
std::cout << "@ ";
} else {
if(state[x][y] == 0) {
std:: cout << " ";
} else {
std:: cout << state[x][y] << " ";
}
}
}
std::cout << std::endl;
}
}

void print() {
std::cout << " ";
for(int x = 0; x < DIMX; x++) {
std::cout << (x + 1) << " ";
}
std::cout << std::endl << "";
for(int x = 0; x < DIMX; x++) {
std::cout << "";
}
std::cout << std::endl;
for(int y = 0; y < DIMY; y++) {
std::cout << (y + 1) << " ";
for(int x = 0; x < DIMX; x++) {
if(display[x][y] == COVERED || display[x][y] == 'F') { // is it tile still uncovered
std::cout << display[x][y] << " ";
} else { // display the state
if(state[x][y] == MINE) {
std::cout << "@ ";
} else {
if(state[x][y] == 0) {
std:: cout << " ";
} else {
std:: cout << state[x][y] << " ";
}
}
}
}

std::cout << std::endl;
}
}

Related Questions

C++ in Xcode Pass the values by reference to complete the programming tasks. Usi
Question #3799450
C++ in Xcode Required Classes and Methods NOT functions. Programmers must apply
Question #3862196
C++ in a UNIX Environment Part1 Create a one-directional ring of pipe for N proc
Question #665572
C++ in a UNIX environment Create a one-directional circular buffer (ring) of pip
Question #665583
C++ in a UNIX environment Part1 - Create a one-directional circular buffer (ring
Question #665576
C++ in xcode (Mac) help //This is header part of C++ #include\"brickGame.h\" #in
Question #3837961
C++ in xcode (Mac) help 1. 2. By File By Type 0 unknown type name coORD 0 Unknow
Question #3837377
C++ in xcode (Mac) help Can someone help me create a .h file (bringGame.h file)
Question #3838366
Hire Me For All Your Tutoring Needs
Integrity-first tutoring: clear explanations, guidance, and feedback.
Drop an Email at
drjack9650@gmail.com
Chat Now And Get Quote

Navigate

Previous
C++ minesweeper coding... posted below at the bottom is my code which meets all
Next
C++ mouse maze Using the Stack class, write a complete program for a mouse to fi

Integrity-first tutoring: explanations and feedback only — we do not complete graded work. Learn more.